Prototype Test for Pull Request to ask about best way to handle Wire.… #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this PR! I ran into the same problem when debugging #7 on a ReadBoard Plus. Some platforms (eg. ESP32) make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors with the default 1.8.19 IDE when trying to compile this example. I looked up wire.begin() on Arduino's documentation page and it returns void (not an int/bool.)
This change would let it compile, but is there a better way to do this? I imagine I'm missing something though. I skimmed the Arduino wire.* methods and didn't see anything that would indicate success in starting the interface.
If this is reasonable, I will expand the final pull request to include all 4 examples.